-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add type checking in package tests directory #19320
chore: add type checking in package tests directory #19320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! waiting for CI
Codecov Report
@@ Coverage Diff @@
## master #19320 +/- ##
=======================================
Coverage 66.64% 66.65%
=======================================
Files 1674 1674
Lines 64602 64603 +1
Branches 6498 6500 +2
=======================================
+ Hits 43057 43058 +1
Misses 19862 19862
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit b0397be)
SUMMARY
This PR adds type checking in package tests directory.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
Run
npm run type
in superset-frontend directoryADDITIONAL INFORMATION