-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import external management columns #19315
feat: import external management columns #19315
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19315 +/- ##
==========================================
- Coverage 66.65% 66.63% -0.03%
==========================================
Files 1672 1672
Lines 64611 64622 +11
Branches 6505 6505
==========================================
- Hits 43066 43060 -6
- Misses 19862 19879 +17
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* feat: import flags * Add tests (cherry picked from commit c7f9060)
* feat: import flags * Add tests
SUMMARY
Allow imports to pass
is_managed_externally
andexternal_url
to indicate that these assets are being managed outside of Superset. Currently this is just stored as metadata, but in the future the columns should be used to disable edits and point users to the source of truth where the resources can be managed.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION