Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import external management columns #19315

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Mar 22, 2022

SUMMARY

Allow imports to pass is_managed_externally and external_url to indicate that these assets are being managed outside of Superset. Currently this is just stored as metadata, but in the future the columns should be used to disable edits and point users to the source of truth where the resources can be managed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Added unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title feat: import flags feat: import external management columns Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #19315 (b043c2d) into master (7ca10fb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head b043c2d differs from pull request most recent head 53d6a7c. Consider uploading reports for the commit 53d6a7c to get more accurate results

@@            Coverage Diff             @@
##           master   #19315      +/-   ##
==========================================
- Coverage   66.65%   66.63%   -0.03%     
==========================================
  Files        1672     1672              
  Lines       64611    64622      +11     
  Branches     6505     6505              
==========================================
- Hits        43066    43060       -6     
- Misses      19862    19879      +17     
  Partials     1683     1683              
Flag Coverage Δ
hive 52.66% <100.00%> (+0.01%) ⬆️
mysql ?
postgres 81.70% <100.00%> (-0.01%) ⬇️
presto 52.51% <100.00%> (+0.01%) ⬆️
python 82.07% <100.00%> (-0.05%) ⬇️
sqlite 81.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/Menu.tsx 60.00% <ø> (ø)
superset/charts/schemas.py 99.34% <100.00%> (+<0.01%) ⬆️
superset/connectors/base/models.py 88.65% <100.00%> (+0.03%) ⬆️
superset/dashboards/schemas.py 99.42% <100.00%> (+<0.01%) ⬆️
superset/databases/schemas.py 98.49% <100.00%> (+0.01%) ⬆️
superset/datasets/schemas.py 97.22% <100.00%> (+0.03%) ⬆️
superset/models/core.py 88.33% <100.00%> (-0.72%) ⬇️
superset/models/dashboard.py 75.57% <100.00%> (+0.09%) ⬆️
superset/models/slice.py 85.43% <100.00%> (+0.07%) ⬆️
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca10fb...53d6a7c. Read the comment docs.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@betodealmeida betodealmeida merged commit c7f9060 into apache:master Mar 24, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* feat: import flags

* Add tests

(cherry picked from commit c7f9060)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants