-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom SQL in Sort By Breaks Bar Chart #19069
fix: custom SQL in Sort By Breaks Bar Chart #19069
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19069 +/- ##
==========================================
- Coverage 66.50% 66.32% -0.18%
==========================================
Files 1642 1642
Lines 63442 63442
Branches 6439 6439
==========================================
- Hits 42191 42081 -110
- Misses 19582 19691 +109
- Partials 1669 1670 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…custom-sql-sort-breaks-bar-chart
If you happen to capture before/after GIFs/videos/screenshots for changes like this, it can often help with the repro of this issue, and provide historical context we sometimes refer back to. |
/testenv up |
@rusackas Ephemeral environment spinning up at http://35.87.115.171:8080. Credentials are |
LGTM, and seems to be working in testing. Just pinging @villebro for a quick 👀 in case he knows of any particular reasoning for the way it was before. |
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 4f0074a)
SUMMARY
When adding custom SQL to the Sort by field, the Bar chart results return, but the visualization doesn’t render
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION