Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom SQL in Sort By Breaks Bar Chart #19069

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

When adding custom SQL to the Sort by field, the Bar chart results return, but the visualization doesn’t render

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a bar chart
  2. Add a sum() to the metrics, a text column to Series, a text column to Breakdown
  3. Manually add a Sort by, typing in one of the column names from the Series or Breakdown fields
  4. Run the query

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #19069 (7d0f4de) into master (f9c7405) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 7d0f4de differs from pull request most recent head 32099cf. Consider uploading reports for the commit 32099cf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19069      +/-   ##
==========================================
- Coverage   66.50%   66.32%   -0.18%     
==========================================
  Files        1642     1642              
  Lines       63442    63442              
  Branches     6439     6439              
==========================================
- Hits        42191    42081     -110     
- Misses      19582    19691     +109     
- Partials     1669     1670       +1     
Flag Coverage Δ
hive ?
mysql 81.81% <100.00%> (ø)
postgres 81.86% <100.00%> (ø)
presto ?
python 81.94% <100.00%> (-0.35%) ⬇️
sqlite 81.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 58.26% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.00% <0.00%> (-15.77%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-5.65%) ⬇️
superset-frontend/src/views/components/Menu.tsx 56.41% <0.00%> (-2.57%) ⬇️
superset/connectors/sqla/models.py 88.87% <0.00%> (-1.24%) ⬇️
superset/db_engine_specs/base.py 89.14% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.67% <0.00%> (-0.25%) ⬇️
superset/utils/core.py 90.13% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c7405...32099cf. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Mar 9, 2022

If you happen to capture before/after GIFs/videos/screenshots for changes like this, it can often help with the repro of this issue, and provide historical context we sometimes refer back to.

@rusackas
Copy link
Member

rusackas commented Mar 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

@rusackas Ephemeral environment spinning up at http://35.87.115.171:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas requested a review from villebro March 16, 2022 14:24
@rusackas
Copy link
Member

LGTM, and seems to be working in testing. Just pinging @villebro for a quick 👀 in case he knows of any particular reasoning for the way it was before.

@rusackas rusackas merged commit 4f0074a into apache:master Mar 18, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants