-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deck.gl): make Deck.gl Javascript tooltip generator works correctly #19059
fix(deck.gl): make Deck.gl Javascript tooltip generator works correctly #19059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the fix and for pointing this out.
Codecov Report
@@ Coverage Diff @@
## master #19059 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1641 1641
Lines 63476 63476
Branches 6444 6444
=======================================
Hits 42227 42227
Misses 19585 19585
Partials 1664 1664
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
(cherry picked from commit 2cc5678)
@chanyou0311 Your suggested solution seems to be "I installed vm-browserify and specified it in webpack.config.js.". Can you please provide more details? How and where to install vm-browserify and how to specify it in webpack.config.js. Thanks in advance |
Set TALISMAN_ENABLED = False in superset_config.py will remove minifed react #31 for the tooltip generator. |
Rather than disabling Talisman entirely, I wonder what holes would need to be poked in its configuration to allow this to work without removing all other safeguards. |
SUMMARY
This PR fixed the problem that JAVASCRIPT TOOLTIP GENERATOR of Deck.gl is not working.
I installed
vm-browserify
and specified it inwebpack.config.js
.Because Webpack 5 no longer polyfills and
vm
module is used atsandboxedEval
function definedsuperset/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils/sandbox.js
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
before_capture.mp4
After
after_capture.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION