-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add previous line hotkey to SQL Lab for macOS #19052
fix: add previous line hotkey to SQL Lab for macOS #19052
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19052 +/- ##
==========================================
- Coverage 66.52% 66.52% -0.01%
==========================================
Files 1641 1641
Lines 63476 63480 +4
Branches 6444 6445 +1
==========================================
+ Hits 42227 42228 +1
- Misses 19585 19587 +2
- Partials 1664 1665 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.24.191.186:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally circled back to test on the ephemeral env. Looks good! It might be nice to add some tests here in the near future, since it doesn't look like ANY of these hotkeys have tests.
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit aa0ec71)
SUMMARY
Adds an extra ctrl+p hotkey for macOS only that navigates to the previous line in SQL Lab editor.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION