Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve cypress flakiness #19044

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Mar 7, 2022

SUMMARY

We still see a decent number of flaky Cypress tests. Buming from 1 retry to 2 retries on failed tests should significantly reduce the number of cypress failures, while only barely increasing test run time (since the retries will only happen on failure).

TESTING INSTRUCTIONS

CI

to: @john-bodley @michael-s-molina @graceguo-supercat @ktmud @rusackas

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #19044 (634e7dc) into master (1b7d056) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 634e7dc differs from pull request most recent head 2fb08c2. Consider uploading reports for the commit 2fb08c2 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19044   +/-   ##
=======================================
  Coverage   66.33%   66.33%           
=======================================
  Files        1641     1641           
  Lines       63476    63476           
  Branches     6444     6444           
=======================================
+ Hits        42106    42109    +3     
+ Misses      19704    19703    -1     
+ Partials     1666     1664    -2     
Flag Coverage Δ
javascript 51.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 64.67% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7d056...2fb08c2. Read the comment docs.

@etr2460 etr2460 merged commit 002bd6e into apache:master Mar 7, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants