Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(embedded): add optional dashboard ui configuration #19031

Merged
merged 4 commits into from
Mar 11, 2022
Merged

feat(embedded): add optional dashboard ui configuration #19031

merged 4 commits into from
Mar 11, 2022

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Mar 4, 2022 •
edited
Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • published to under my personal npm and tested

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang requested a review from suddjian March 4, 2022 19:11
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Mar 9, 2022
@lilykuang lilykuang requested a review from suddjian March 9, 2022 23:05
suddjian
suddjian approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lilykuang lilykuang merged commit 124cb0d into apache:master Mar 11, 2022
@lilykuang lilykuang deleted the dashboard-ui-config-sdk branch March 11, 2022 20:37
villebro pushed a commit that referenced this pull request Apr 3, 2022
@villebro
feat(embedded): add optional dashboard ui configuration (#19031)
2b8b9b3 
* feat: add optional dashboard ui configuration

* change all flags to boolean

* update README and lint

(cherry picked from commit 124cb0d)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilykuang @suddjian @mistercrunch @villebro