Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add perm for showing DBC-UI in Global Nav #19023

Merged
merged 3 commits into from
Mar 11, 2022
Merged

fix: Add perm for showing DBC-UI in Global Nav #19023

merged 3 commits into from
Mar 11, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 4, 2022 •
edited
Loading

SUMMARY

Add perm check for showing DBC-UI inside the global nav create nav button, users must have can_write -> Database to be able to see the links

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Copy link
Member

eschutho commented Mar 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

@eschutho Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

@eschutho Ephemeral environment creation failed. Please check the Actions logs for details.

@eschutho eschutho added the need:qa-review Requires QA review label Mar 4, 2022
@eschutho
Copy link
Member

eschutho commented Mar 4, 2022

cc @yousoph

@yousoph
Copy link
Member

yousoph commented Mar 4, 2022

/testenv up

@codecov
Copy link

codecov bot commented Mar 4, 2022 •
edited
Loading

Codecov Report

Merging #19023 (adfddbf) into master (77063cc) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19023      +/-   ##
==========================================
- Coverage   66.56%   66.55%   -0.01%     
==========================================
  Files        1641     1656      +15     
  Lines       63495    66267    +2772     
  Branches     6425     7394     +969     
==========================================
+ Hits        42265    44106    +1841     
- Misses      19550    20332     +782     
- Partials     1680     1829     +149
Flag Coverage Δ
hive 52.59% <ø> (ø)
javascript 52.40% <50.00%> (+1.03%) ⬆️
mysql 81.81% <ø> (ø)
postgres 81.86% <ø> (ø)
presto 52.44% <ø> (ø)
python 82.29% <ø> (ø)
sqlite 81.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/components/MenuRight.tsx 65.71% <50.00%> (-6.42%) ⬇️
...s/legacy-preset-chart-nvd3/src/Bar/controlPanel.ts 28.57% <0.00%> (-71.43%) ⬇️
...ts/nativeFilters/FilterBar/FilterControls/utils.ts 57.14% <0.00%> (-12.86%) ⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx 77.35% <0.00%> (-4.79%) ⬇️
...ns/plugin-chart-echarts/src/Radar/controlPanel.tsx 28.57% <0.00%> (-4.77%) ⬇️
...oard/components/nativeFilters/FilterCard/Styles.ts 80.00% <0.00%> (-4.62%) ⬇️
...src/dashboard/components/FiltersBadge/selectors.ts 67.20% <0.00%> (-3.45%) ⬇️
...d/components/nativeFilters/FilterCard/ScopeRow.tsx 69.56% <0.00%> (-3.17%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 76.56% <0.00%> (-2.84%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77063cc...adfddbf. Read the comment docs.

@hughhhh
Copy link
Member Author

hughhhh commented Mar 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

@hughhhh Ephemeral environment spinning up at http://35.86.172.78:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 4, 2022
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 4, 2022
@hughhhh
Copy link
Member Author

hughhhh commented Mar 4, 2022 •
edited
Loading

With gamma role set by attaching can_write Database to it:
Screen Shot 2022-03-04 at 11 37 54 AM

@hughhhh
Copy link
Member Author

hughhhh commented Mar 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

@hughhhh Ephemeral environment spinning up at http://34.220.146.9:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 9, 2022
pkdotson
pkdotson approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yousoph
Copy link
Member

yousoph commented Mar 10, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.215.223.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 10, 2022
@hughhhh hughhhh merged commit c337491 into master Mar 11, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@villebro villebro added lts-v1 and removed need:qa-review Requires QA review labels Mar 29, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@hughhhh @villebro
fix: Add perm for showing DBC-UI in Global Nav (#19023)
20fd7a7 
* add perm for global db add

* fix permissions

* missing roles params

(cherry picked from commit c337491)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the add-perm-global-db branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAfghahi AAfghahi AAfghahi approved these changes

@pkdotson pkdotson pkdotson approved these changes

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hughhhh @eschutho @yousoph @pkdotson @AAfghahi @mistercrunch @villebro