-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow uploads in crud view #18953
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18953 +/- ##
==========================================
- Coverage 66.54% 66.52% -0.03%
==========================================
Files 1646 1643 -3
Lines 63630 63589 -41
Branches 6475 6494 +19
==========================================
- Hits 42343 42301 -42
Misses 19607 19607
- Partials 1680 1681 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@yousoph Ephemeral environment spinning up at http://52.38.37.16:8080. Credentials are |
@pkdotson
|
One more text change: should be "Upload Excel file" |
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.218.239.39:8080. Credentials are |
…eat-uploads-crudview
superset-frontend/src/views/CRUD/data/database/DatabaseList.tsx
Outdated
Show resolved
Hide resolved
Ephemeral environment shutdown and build artifacts deleted. |
* feat: allow uploads in crud view * fix merge conflict and fix ts * fix import * fix tests * fix lint * remove unused var * fix underline flash and alignment * fix offset * fix icon alignment * fix labels and css issues * make drowdown primary all the time * make global * fix lables * add upload perms to utils * remove unused code * add suggested changes * update menuright
* feat: allow uploads in crud view * fix merge conflict and fix ts * fix import * fix tests * fix lint * remove unused var * fix underline flash and alignment * fix offset * fix icon alignment * fix labels and css issues * make drowdown primary all the time * make global * fix lables * add upload perms to utils * remove unused code * add suggested changes * update menuright (cherry picked from commit d771ddb)
SUMMARY
This pr creates an additional dropdown in the subnav for the upload in the database crud view.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-03-10.at.9.13.38.AM.mov
TESTING INSTRUCTIONS
Go to database crud view page and test upload a file dropdown.
ADDITIONAL INFORMATION