-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legacy-preset-chart-deckgl): Add ,.1f and ,.2f value formats to deckgl charts #18945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/controls.jsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #18945 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1640 1641 +1
Lines 63514 63522 +8
Branches 6418 6421 +3
=======================================
+ Hits 42164 42170 +6
- Misses 19690 19691 +1
- Partials 1660 1661 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to provide more format for this chart, we just add freeForm: true
for format control in Deckgl.
Thanks for pointing that out @zhaoyongjie. @yousoph @rusackas should we add those formatters in other charts as well? Should we quick and simple. |
Thanks for pointing that out, @zhaoyongjie ! |
@zhaoyongjie @yousoph Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement!
SUMMARY
This PR adds 2 new formattings to Legend Format control in deckgl charts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Verify that ,.1f and ,.2f legend formattings are available and work correctly
ADDITIONAL INFORMATION
https://app.shortcut.com/preset/story/37656/add-1f-and-2f-to-the-legend-format-option-for-deck-gl-charts