fix(sqllab): Un-render deselected tabs #18934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When you switch tabs in sql lab, we were keeping them all rendered in the dom, but hidden. This meant that everytime the sql lab redux state changed, we'd re-render all tabs that were viewed since the last page load. This prop is defined on antd tabs (https://ant.design/components/tabs/#API), and un-renders tabs that aren't currently selected, improving the perf of both switching tabs and updating the sql query being run.
TESTING INSTRUCTIONS
go to SQL Lab, change tabs and see the old tabs un-rendered from the DOM. Ensure all SQL Lab functionality still works
to: @kgabryje @ktmud @rusackas @john-bodley