-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter indicator pointing issue on popover #18853
fix: filter indicator pointing issue on popover #18853
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18853 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 1620 1621 +1
Lines 63045 63057 +12
Branches 6377 6382 +5
=======================================
+ Hits 41842 41850 +8
- Misses 19544 19547 +3
- Partials 1659 1660 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://50.112.85.171:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pointing of the popover in the indicator look more accurate with the change. LGTM!
Screen.Recording.2022-02-24.at.10.12.48.AM.mov
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Original report:
When chart is at max length, pointer of the filter indicator is not pointing correctly.
Grooming report:
bottomRight
as the placement of popover because all of filter badge icons are placed on top right corner of its section.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS