Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter indicator pointing issue on popover #18853

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

Original report:
When chart is at max length, pointer of the filter indicator is not pointing correctly.

Grooming report:

  1. This issue is related to the placement of popover. We could use bottomRight as the placement of popover because all of filter badge icons are placed on top right corner of its section.
  2. Popover is being triggered for filter badge icons only for now.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
image

AFTER
image

TESTING INSTRUCTIONS

  1. Go to dashboard
  2. Click filter badge icon on the right side chart component.
  3. See if the popover is placed on bottom-right.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #18853 (ce9770f) into master (4c16586) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18853   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        1620     1621    +1     
  Lines       63045    63057   +12     
  Branches     6377     6382    +5     
=======================================
+ Hits        41842    41850    +8     
- Misses      19544    19547    +3     
- Partials     1659     1660    +1     
Flag Coverage Δ
javascript 51.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ard/components/FiltersBadge/DetailsPanel/index.tsx 81.81% <ø> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 66.94% <0.00%> (-2.88%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 72.72% <0.00%> (-2.57%) ⬇️
superset-frontend/src/dashboard/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <0.00%> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <0.00%> (ø)
superset-frontend/src/utils/common.js 89.47% <0.00%> (+0.18%) ⬆️
...ilters/FilterBar/FilterControls/FilterControls.tsx 77.77% <0.00%> (+0.63%) ⬆️
...nents/nativeFilters/FilterBar/FilterSets/index.tsx 37.66% <0.00%> (+0.82%) ⬆️
...omponents/nativeFilters/FilterBar/Header/index.tsx 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c16586...ce9770f. Read the comment docs.

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://50.112.85.171:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@apache apache deleted a comment from github-actions bot Feb 24, 2022
@apache apache deleted a comment from github-actions bot Feb 24, 2022
Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pointing of the popover in the indicator look more accurate with the change. LGTM!

Screen.Recording.2022-02-24.at.10.12.48.AM.mov

@rusackas rusackas merged commit c1ee75d into apache:master Feb 24, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants