Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(native filter): add new native filter test for time column filter #18850

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

jinghua-qa
Copy link
Member

@jinghua-qa jinghua-qa commented Feb 22, 2022

add new native filter test : User can create a time column filter

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #18850 (420ccbf) into master (0ae1ca7) will not change coverage.
The diff coverage is n/a.

❗ Current head 420ccbf differs from pull request most recent head 6eb8d98. Consider uploading reports for the commit 6eb8d98 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18850   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files        1633     1633           
  Lines       63210    63210           
  Branches     6409     6409           
=======================================
  Hits        41852    41852           
  Misses      19698    19698           
  Partials     1660     1660           
Flag Coverage Δ
javascript 51.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae1ca7...6eb8d98. Read the comment docs.

@jinghua-qa jinghua-qa marked this pull request as draft February 23, 2022 17:03
@jinghua-qa jinghua-qa marked this pull request as ready for review February 23, 2022 17:37
@michael-s-molina
Copy link
Member

@jinghua-qa The size of this file is getting quite big and a lot of functionality is being repeated between the tests. I think it's time to refactor this code and extract the common behaviors to functions so it's easier to read.

@jinghua-qa
Copy link
Member Author

@jinghua-qa The size of this file is getting quite big and a lot of functionality is being repeated between the tests. I think it's time to refactor this code and extract the common behaviors to functions so it's easier to read.

That is a very good suggestion~ I will plan for this refactor project and do it in another PR

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the observation to refactor this code in a follow-up PR.

@jinghua-qa jinghua-qa merged commit 0af671f into apache:master Feb 24, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io Preset-QA size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants