Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(altered-modal): make specified text fields wrap in table #18822

Merged
merged 5 commits into from
Mar 9, 2022
Merged

fix(altered-modal): make specified text fields wrap in table #18822

merged 5 commits into from
Mar 9, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Feb 19, 2022 •
edited
Loading

SUMMARY

Altered Modal Doesn't Scroll or Wrap Text

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 19, 2022 •
edited
Loading

Codecov Report

Merging #18822 (a573b30) into master (c8df849) will increase coverage by 0.02%.
The diff coverage is 66.25%.

❗ Current head a573b30 differs from pull request most recent head 3419726. Consider uploading reports for the commit 3419726 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18822      +/-   ##
==========================================
+ Coverage   66.31%   66.34%   +0.02%     
==========================================
  Files        1620     1641      +21     
  Lines       63075    63479     +404     
  Branches     6370     6446      +76     
==========================================
+ Hits        41827    42112     +285     
- Misses      19591    19703     +112     
- Partials     1657     1664       +7
Flag Coverage Δ
javascript 51.29% <66.25%> (+0.04%) ⬆️
mysql ?
postgres ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-chart-controls/src/sections/sections.tsx 100.00% <ø> (ø)
...chart-controls/src/shared-controls/dndControls.tsx 35.89% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.36% <ø> (+0.36%) ⬆️
...perset-ui-chart-controls/src/utils/D3Formatting.ts 100.00% <ø> (ø)
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...ckages/superset-ui-core/src/query/extractExtras.ts 100.00% <ø> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <ø> (ø)
...ins/legacy-preset-chart-deckgl/src/Multi/Multi.jsx 0.00% <0.00%> (ø)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8df849...3419726. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.162.207.97:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

rusackas commented Mar 1, 2022

We should probably limit this change to particular columns (via a prop?) or at least to this particular modal. This change is global enough that it's affecting other areas such as the CRUD view:

image

Pinging @nytai who wrote the original styles, in case I'm overthinking it and wrapping everywhere seems like an acceptable change.

rusackas
rusackas requested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should narrow the scope of the modal so there's no global fallout.

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Mar 2, 2022
@prosdev0107 prosdev0107 closed this Mar 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

Ephemeral environment shutdown and build artifacts deleted.

@prosdev0107 prosdev0107 reopened this Mar 2, 2022
@rusackas
Copy link
Member

rusackas commented Mar 7, 2022

/testenv up

@rusackas rusackas changed the title fix(altered-modal): make all text fields wrap fix(altered-modal): make specified text fields wrap in table Mar 7, 2022
@rusackas
Copy link
Member

rusackas commented Mar 7, 2022

Updated the PR title to make it reflect the change more accurately. Feel free to change my wording as needed.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

@rusackas Ephemeral environment spinning up at http://52.40.145.198:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 220c461 into apache:master Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
@prosdev0107 @villebro
fix(altered-modal): make specified text fields wrap in table (#18822)
4462cfe 
* fix(altered-modal): make all text fields wrap

* fix(altered-modal): limit the wrap text in particular column

* fix(altered-modal): make to update the unit test

* fix(altered-modal): make to fix the type of columnsForWrapText

* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type

(cherry picked from commit 220c461)
@mistercrunch mistercrunch added 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prosdev0107 @rusackas @mistercrunch @villebro