Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(altered-modal): displayed the metric value in altered modal correctly #18813

Merged
merged 6 commits into from
Feb 21, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Feb 18, 2022

SUMMARY

Altered Modal Doesn't Show Metrics Properly

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Member

geido commented Feb 18, 2022

Hello @prosdev0107 thanks for the PR. There are some linting issues to fix. Also, I don't think you need to tick the "Changes UI" checkbox in the PR description as that is intended for changes that affect the UI, in this case, this is just a fix of standard behavior.

@rusackas
Copy link
Member

Hello @prosdev0107 thanks for the PR. There are some linting issues to fix. Also, I don't think you need to tick the "Changes UI" checkbox in the PR description as that is intended for changes that affect the UI, in this case, this is just a fix of standard behavior.

Agreed on the checkbox, though I appreciate over-checking rather than under-checking :)

To run the linter locally, just run npm run lint-fix from within the superset-frontend folder you can also install the pre-commit hooks if you'd like (I would need to dig up the command if so, since I don't remember it offhand)

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas
Copy link
Member

Approved and waiting for CI. As with all fix PRs, it'd be great if there were a test. Let me know if that looks like a reasonably easy addition here.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #18813 (bb27062) into master (c8df849) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18813   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1620     1620           
  Lines       63075    63090   +15     
  Branches     6370     6375    +5     
=======================================
+ Hits        41827    41837   +10     
- Misses      19591    19594    +3     
- Partials     1657     1659    +2     
Flag Coverage Δ
javascript 51.25% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AlteredSliceTag/AlteredSliceTagMocks.js 100.00% <ø> (ø)
...-frontend/src/components/AlteredSliceTag/index.jsx 87.69% <33.33%> (-2.64%) ⬇️
...perset-frontend/src/views/components/MenuRight.tsx 80.00% <0.00%> (-0.49%) ⬇️
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.73% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 69.82% <0.00%> (ø)
...lLab/components/ExploreCtasResultsButton/index.jsx
...lLab/components/ExploreCtasResultsButton/index.tsx 8.33% <0.00%> (ø)
...-frontend/src/components/CopyToClipboard/index.jsx 96.00% <0.00%> (+0.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8df849...bb27062. Read the comment docs.

@rusackas rusackas added the need:tests This PR requires tests label Feb 19, 2022
@nytai nytai removed the need:tests This PR requires tests label Feb 21, 2022
@nytai nytai merged commit 3c17c60 into apache:master Feb 21, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants