Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FF): adding generic X axis Feature Flag (default: False) #18801

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

The product has already supported the GENERIC_CHART_AXES feature flag, but it was not set in config.py with a default/overridable setting. This PR merely plops it in there, and should have no visible/functional change to a default configured deployment of Superset.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A, but flip the flag and check out the cool new features if you'd like

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #18801 (9d09fab) into master (8dc2377) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18801   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1620     1620           
  Lines       63088    63088           
  Branches     6372     6372           
=======================================
  Hits        41839    41839           
  Misses      19592    19592           
  Partials     1657     1657           
Flag Coverage Δ
hive 52.22% <ø> (ø)
javascript 51.25% <ø> (ø)
mysql 81.42% <ø> (ø)
postgres 81.47% <ø> (ø)
presto 52.06% <ø> (ø)
python 81.90% <ø> (ø)
sqlite 81.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc2377...9d09fab. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review February 18, 2022 03:34
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 80d66dd into master Feb 18, 2022
@rusackas rusackas deleted the add-generic-x-axis-ff branch February 18, 2022 17:29
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 24, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.7

@sadpandajoe
Copy link
Member

🏷 preset:2022.7

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.7 preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants