Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embedded): make guest token JWT audience callable or str #18748

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

lilykuang
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #18748 (9cb62f1) into master (c8df849) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head 9cb62f1 differs from pull request most recent head 61c1a99. Consider uploading reports for the commit 61c1a99 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18748      +/-   ##
==========================================
- Coverage   66.31%   66.14%   -0.17%     
==========================================
  Files        1620     1620              
  Lines       63075    63080       +5     
  Branches     6370     6370              
==========================================
- Hits        41827    41725     -102     
- Misses      19591    19698     +107     
  Partials     1657     1657              
Flag Coverage Δ
hive ?
mysql 81.42% <100.00%> (+<0.01%) ⬆️
postgres 81.47% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.55% <100.00%> (-0.35%) ⬇️
sqlite 81.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.92% <100.00%> (ø)
superset/security/manager.py 94.38% <100.00%> (+0.05%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-15.45%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-5.65%) ⬇️
superset/connectors/sqla/models.py 87.33% <0.00%> (-1.44%) ⬇️
superset/db_engine_specs/base.py 88.38% <0.00%> (-0.37%) ⬇️
superset/models/core.py 88.86% <0.00%> (-0.25%) ⬇️
superset/utils/core.py 90.15% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8df849...61c1a99. Read the comment docs.

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - might be easier to impl as a helper method in the SM

@lilykuang lilykuang merged commit b2613f6 into apache:master Feb 16, 2022
@lilykuang lilykuang deleted the make-guest-token-audience-callable branch February 16, 2022 01:47
@apole
Copy link

apole commented May 15, 2023

GUEST_TOKEN_JWT_AUDIENCE should be set to the domain name of the application that is embedding Superset or the superset Server?.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants