Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maps): Adding country maps: BI/ET/RW/TZ/UG (+updated NG) #18745

Merged
merged 1 commit into from
Feb 16, 2022
Merged

feat(maps): Adding country maps: BI/ET/RW/TZ/UG (+updated NG) #18745

merged 1 commit into from
Feb 16, 2022

Conversation

Yann-J
Copy link
Contributor

@Yann-J Yann-J commented Feb 15, 2022

SUMMARY

This adds admin boundary country maps for 5 countries in Africa (+ updates NG). All generated from the Jupyter notebook (also updated) - no tweaks required.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Updated country shapes:

countries

TESTING INSTRUCTIONS

  • Create Country map for any of the above country

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #18745 (03e76a7) into master (8b3e27d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18745   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1620     1620           
  Lines       63061    63061           
  Branches     6368     6368           
=======================================
  Hits        41823    41823           
  Misses      19580    19580           
  Partials     1658     1658           
Flag Coverage Δ
javascript 51.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3e27d...03e76a7. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review February 16, 2022 03:20
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, restarted CI

@rusackas rusackas merged commit 4f12e27 into apache:master Feb 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants