-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): fix default filter bar visibility + add docs #18741
fix(dashboard): fix default filter bar visibility + add docs #18741
Conversation
5d2ffa2
to
ea15b7d
Compare
ea15b7d
to
aa1e1c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #18741 +/- ##
==========================================
- Coverage 66.64% 66.57% -0.08%
==========================================
Files 1670 1667 -3
Lines 64590 64419 -171
Branches 6506 6505 -1
==========================================
- Hits 43047 42887 -160
+ Misses 19860 19849 -11
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aa1e1c6
to
fef31c4
Compare
fef31c4
to
7ae3735
Compare
/testenv up |
@villebro Ephemeral environment spinning up at http://35.86.100.235:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested many combinations of standalone, show filters, expand filters, couldn't break anything. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @kgabryje and @jinghua-qa for review/testing! |
Ephemeral environment shutdown and build artifacts deleted. |
…18741) * fix(dashboard): fix default filter tab visibility + add tests * fix types * lint * rename docs + add double bang to length
* fix(dashboard): fix default filter tab visibility + add tests * fix types * lint * rename docs + add double bang to length (cherry picked from commit b7ecb14)
…18741) * fix(dashboard): fix default filter tab visibility + add tests * fix types * lint * rename docs + add double bang to length
SUMMARY
This adds docs for reserved/supported URL parameters in the dashboard view. While writing docs for the Dashboard URL params, I noticed some inconsistencies in how they work:
getUrlParam
was missingnull
which it defaults to when the param is missingshow_native_filters
does. Here we recycle theshow_filters
URL param to mimic the behavior ofshow_native_filters
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
expand_filters=1
on the URL to forcefully expand the Filter Bar: http://35.86.100.235:8080/superset/dashboard/10/?expand_filters=1expand_filters=0
on the URL to forcefully collapse the Filter Bar: http://35.86.100.235:8080/superset/dashboard/10/?expand_filters=0show_filters=0
to forcefully disable native filters (handy for standalone mode): http://35.86.100.235:8080/superset/dashboard/10/?show_filters=0standalone=0
to verify that it looks like the default configuration: http://35.86.100.235:8080/superset/dashboard/5/?standalone=0standalone=1
to see that the top nav is removed: http://35.86.100.235:8080/superset/dashboard/5/?standalone=1standalone=2
to see that the top nav + title is removed: http://35.86.100.235:8080/superset/dashboard/5/?standalone=2standalone=3
to see that the top nav + title + top tabs are removed: http://35.86.100.235:8080/superset/dashboard/5/?standalone=3standalone=3&show_filters=0
to make sure filter bar, nav, title and top tabs are removed: http://35.86.100.235:8080/superset/dashboard/5/?standalone=3&show_filters=0ADDITIONAL INFORMATION