Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report list search by created_by #18725

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 15, 2022

SUMMARY

This PR is to fix the issue when search by created_by in report/alert list.
Steps to reproduce (see issue##17162)

  1. open alert/report list
  2. In CREATED BY, search for a username, for example "Grace".

Screen Shot 2022-02-14 at 5 05 57 PM

  1. It will generate a request to /related/ endpoint: Request URL: https://superset.d.musta.ch/api/v1/report/related/created_by?q=(filter:grace,page:0,page_size:100)
  2. But for report schedule, it has owners in related_field_filters, not created_by. This mis-match cause filter didn't take any effect.

The proposed fix is to use created_by in the related_field_filters.

TESTING INSTRUCTIONS

CI and manual test

@graceguo-supercat graceguo-supercat merged commit 59b811a into apache:master Feb 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants