-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Implement empty states for dashboard #18712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Tested, and feels much more intuitive than the current behavior!
@@ -35,7 +35,7 @@ export interface EmptyStateSmallProps { | |||
} | |||
|
|||
export interface EmptyStateProps extends EmptyStateSmallProps { | |||
buttonText?: string; | |||
buttonText?: string | ReactNode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I assume we can omit string
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #18712 +/- ##
==========================================
+ Coverage 66.32% 66.33% +0.01%
==========================================
Files 1619 1619
Lines 62939 62954 +15
Branches 6341 6348 +7
==========================================
+ Hits 41742 41762 +20
+ Misses 19545 19537 -8
- Partials 1652 1655 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This PR implements chart empty states for 3 scenarios:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc
https://app.shortcut.com/preset/story/37784/dashboard-empty-states