Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating link to newer viz plugin blog post #18707

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

Updating to the newer link, which is more relevant for the current monorepo situation

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member Author

@villebro I just noticed this link... but it might be worth a look to see if there are more things worth updating in contributing now that we're (finally) a monorepo

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #18707 (990f2f7) into master (225015f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18707      +/-   ##
==========================================
- Coverage   66.28%   66.25%   -0.03%     
==========================================
  Files        1605     1605              
  Lines       62863    62863              
  Branches     6341     6341              
==========================================
- Hits        41666    41650      -16     
- Misses      19545    19561      +16     
  Partials     1652     1652              
Flag Coverage Δ
hive 52.14% <ø> (ø)
javascript 51.28% <ø> (ø)
mysql 81.33% <ø> (ø)
postgres ?
presto 51.98% <ø> (ø)
python 81.76% <ø> (-0.06%) ⬇️
sqlite 81.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 89.13% <0.00%> (-2.18%) ⬇️
superset/db_engine_specs/postgres.py 95.45% <0.00%> (-1.82%) ⬇️
superset/common/query_object.py 95.08% <0.00%> (-0.55%) ⬇️
superset/views/base_api.py 97.47% <0.00%> (-0.43%) ⬇️
superset/reports/commands/execute.py 91.14% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225015f...990f2f7. Read the comment docs.

CONTRIBUTING.md Outdated
[So, You Want to Build a Superset Viz Plugin...](https://preset.io/blog/2020-07-02-hello-world/) blog post
[Building Custom Viz Plugins in Superset v2 (Updated for Monorepo)](https://preset.io/blog/building-custom-viz-plugins-in-superset-v2) blog post
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have official docs for this - should we link to the docs or maybe both? https://superset.apache.org/docs/contributing/creating-viz-plugins

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rusackas rusackas merged commit 4001165 into master Feb 14, 2022
@rusackas rusackas deleted the Updating-link-for-viz-plugin-contriution-info branch February 14, 2022 17:12
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants