-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filter): fix required filters of a dashboard won't load properly #18695
fix(native-filter): fix required filters of a dashboard won't load properly #18695
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18695 +/- ##
==========================================
- Coverage 66.28% 66.26% -0.02%
==========================================
Files 1605 1605
Lines 62863 62865 +2
Branches 6341 6342 +1
==========================================
- Hits 41666 41660 -6
- Misses 19545 19554 +9
+ Partials 1652 1651 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.208.119.115:8080. Credentials are |
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Show resolved
Hide resolved
Could we add a test for this? |
tested in the ephemeral env, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
…operly (apache#18695) (cherry picked from commit 0b1bc5b)
🏷️ preset:2022.7 |
SUMMARY
Fixed the problem that the required Filters of a Dashboard won't load properly when accessing this Dashboard from the Dashboard Gallery after accessing another Gallery.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2022-02-13.10.57.27.mov
after
2022-02-13.10.55.12.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION