Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filter): fix required filters of a dashboard won't load properly #18695

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

Fixed the problem that the required Filters of a Dashboard won't load properly when accessing this Dashboard from the Dashboard Gallery after accessing another Gallery.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-02-13.10.57.27.mov

after

2022-02-13.10.55.12.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ stephenLYZ changed the title fix(native-filter): fix required Filters of a Dashboard won't load properly fix(native-filter): fix required filters of a dashboard won't load properly Feb 13, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #18695 (a4ad1a6) into master (225015f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a4ad1a6 differs from pull request most recent head 5768fce. Consider uploading reports for the commit 5768fce to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18695      +/-   ##
==========================================
- Coverage   66.28%   66.26%   -0.02%     
==========================================
  Files        1605     1605              
  Lines       62863    62865       +2     
  Branches     6341     6342       +1     
==========================================
- Hits        41666    41660       -6     
- Misses      19545    19554       +9     
+ Partials     1652     1651       -1     
Flag Coverage Δ
javascript 51.26% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board/components/nativeFilters/FilterBar/index.tsx 78.37% <100.00%> (-4.20%) ⬇️
superset-frontend/src/dataMask/actions.ts 54.54% <0.00%> (-18.19%) ⬇️
superset-frontend/src/dataMask/reducer.ts 43.33% <0.00%> (-6.67%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225015f...5768fce. Read the comment docs.

@stephenLYZ stephenLYZ closed this Feb 14, 2022
@stephenLYZ stephenLYZ reopened this Feb 14, 2022
@rusackas rusackas requested review from michael-s-molina, zhaoyongjie and geido and removed request for michael-s-molina February 14, 2022 04:38
@geido
Copy link
Member

geido commented Feb 15, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.208.119.115:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

Could we add a test for this?

@jinghua-qa
Copy link
Member

tested in the ephemeral env, LGTM

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 0b1bc5b into apache:master Feb 25, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 25, 2022
@rusackas rusackas added the need:tests This PR requires tests label Feb 25, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.7

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 need:tests This PR requires tests preset:2022.7 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants