Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Native filter): add cypress test user can add time grain filter #18669

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

jinghua-qa
Copy link
Member

SUMMARY

add cypress test user can add time grain filter

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #18669 (6532aa4) into master (33d1c96) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6532aa4 differs from pull request most recent head f9e7e8a. Consider uploading reports for the commit f9e7e8a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18669   +/-   ##
=======================================
  Coverage   66.29%   66.30%           
=======================================
  Files        1603     1603           
  Lines       62770    62772    +2     
  Branches     6322     6323    +1     
=======================================
+ Hits        41616    41618    +2     
  Misses      19502    19502           
  Partials     1652     1652           
Flag Coverage Δ
javascript 51.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.90% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d1c96...f9e7e8a. Read the comment docs.

@jinghua-qa jinghua-qa closed this Feb 11, 2022
@jinghua-qa jinghua-qa reopened this Feb 11, 2022
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jinghua-qa jinghua-qa merged commit e44163e into apache:master Feb 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io Preset-QA size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants