feat(embedded): aud claim and type for guest token #18651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2022 09:29
Codecov Report
@@ Coverage Diff @@
## master #18651 +/- ##
==========================================
+ Coverage 66.29% 66.65% +0.36%
==========================================
Files 1603 1603
Lines 62744 63512 +768
Branches 6320 6320
==========================================
+ Hits 41593 42331 +738
- Misses 19499 19529 +30
Partials 1652 1652
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 2 commits
February 10, 2022 14:37
craig-rueda
reviewed
Feb 11, 2022
| raise ValueError("Guest token does not contain an aud claim") | ||
| if token.get("aud") != aud: | ||
| raise ValueError("Guest token does not match the aud claim") | ||
| if token.get("type") != "guest": |
There was a problem hiding this comment.
Pls add some tests where the supplied token isn't a "guest" token, and where the aud doesn't match
craig-rueda
reviewed
Feb 11, 2022
suddjian
reviewed
Feb 11, 2022
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
added 2 commits
February 11, 2022 13:22
craig-rueda
approved these changes
Feb 14, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION