Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): allow to customize init image #18649

Merged

Conversation

avakarev
Copy link
Contributor

@avakarev avakarev commented Feb 9, 2022

SUMMARY

Init image (busybox) is hard-coded and not customizable via values as image. Some teams (including my team) uses alternative registry (like local image registry proxy). The suggested change is backward-compatible with previous deployment, cause default values are set to previous state.

The initImage has same spec as image and could be used like:

  initImage:
      repository: my-registry/busybox

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

The change could be tested by deploying chart without initImage and with overridden value.

ADDITIONAL INFORMATION

  • Has associated issue
  • Required feature flags
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@avakarev
Copy link
Contributor Author

avakarev commented Feb 9, 2022

@craig-rueda Please take a look when you have a minute.

@craig-rueda
Copy link
Member

Please also bump the chart version

@avakarev
Copy link
Contributor Author

@ad-m @craig-rueda I bumped the chart version. The chart lint should be happy now.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@craig-rueda craig-rueda merged commit 4db70b5 into apache:master Feb 10, 2022
@avakarev avakarev deleted the allow-to-customize-init-image-in-helm-chart branch February 10, 2022 17:44
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants