Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i18n): make translation guide more explicit #18254

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Feb 2, 2022

SUMMARY

Improve the translation section in the new docs:

  • Move the instructions for creating a new language file before the other steps, including instructions to skip to the next section if the target language already exists
  • Add link to ISO 639-1 language codes
  • Add instructions for using poedit under MacOS
  • Make the finalization steps more clear by adding a section "Applying translations"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Go to docs-v2
  2. Run 'yarn install'
  3. Run yarn start
  4. Navigate to http://localhost:3000/docs/Contributing/translations in your browser to check the updated docs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 34335ed into apache:master Feb 3, 2022
@villebro villebro deleted the villebro/doc-translations branch February 3, 2022 10:10
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants