Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker-compose): add TAG option #18214

Merged
merged 1 commit into from
Jan 28, 2022
Merged

feat(docker-compose): add TAG option #18214

merged 1 commit into from
Jan 28, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Jan 28, 2022 •
edited
Loading

SUMMARY

This PR adds a new environment variable TAG to both docker-compose configs to make it possible run a specific tag. In addition, the related doc changes from #18196 are copied over to the new docs site (forthcoming) to keep them in sync with the current docs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Checkout an old release, e.g. 1.4.0
  2. Apply the changes from this PR to the docker-compose yaml files
  3. run TAG=1.4.0 docker-compose -f docker-compose-non-dev.yml up and watch the 1.4.0 version start up successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro merged commit 0a91a68 into apache:master Jan 28, 2022
@villebro villebro deleted the villebro/docker-compose-tag branch January 28, 2022 13:00
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@villebro @shcoderAlex
feat(docker-compose): add TAG option (apache#18214)
7eb5628
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@villebro @ofekisr
feat(docker-compose): add TAG option (apache#18214)
8d31351
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@villebro @bwang221
feat(docker-compose): add TAG option (apache#18214)
0aac290
villebro added a commit that referenced this pull request Mar 21, 2022
@villebro
feat(docker-compose): add TAG option (#18214)
eab47ac
@sujiplr
Copy link
Contributor

sujiplr commented Mar 23, 2022

Much needed enhancement. Loved it..

yangfei4913438 pushed a commit to choice-form/superset that referenced this pull request Apr 2, 2022
@villebro @yangfei4913438
feat(docker-compose): add TAG option (apache#18214)
c1810a2
@mistercrunch mistercrunch added 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S v1.4.2 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@villebro @sujiplr @dpgaspar @mistercrunch