Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea-control): ace editor input exception #18146

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR is to fix the problem that ace-editor in control panel throws an error when the user typing. The reason for this is that we use an onChange callback where the second parameter is an error array by default (see https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/Control.tsx#L65). But for ace-editor, the second parameter of onChange is an event, so we need to wrap it to avoid this exception.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-01-23.11.24.18.mov

after

2022-01-23.11.27.18.mov

TESTING INSTRUCTIONS

follow #18094

ADDITIONAL INFORMATION

  • Has associated issue: Javascript editor duplicate characters #18094
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #18146 (6e5392d) into master (0cec0c9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18146      +/-   ##
==========================================
- Coverage   65.95%   65.95%   -0.01%     
==========================================
  Files        1584     1584              
  Lines       62046    62047       +1     
  Branches     6273     6273              
==========================================
  Hits        40920    40920              
- Misses      19505    19506       +1     
  Partials     1621     1621              
Flag Coverage Δ
javascript 50.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/explore/components/controls/TextAreaControl.jsx 80.00% <0.00%> (-4.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cec0c9...6e5392d. Read the comment docs.

@apache apache deleted a comment from github-actions bot Jan 24, 2022
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 7bb8674 into apache:master Jan 25, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants