Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): support input undo when editing chart title #18137

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Jan 22, 2022

SUMMARY

When user modifies the chart title in the dashboard, it should respond to the browser's default undo/redo action instead of the dashboard's undo event (e.g. layout changed), a similar scenario is the markdown component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-01-23.12.07.22.mov

after

2022-01-23.12.06.31.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #18137 (6b6e598) into master (0cec0c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18137   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files        1584     1584           
  Lines       62046    62047    +1     
  Branches     6273     6274    +1     
=======================================
+ Hits        40920    40921    +1     
  Misses      19505    19505           
  Partials     1621     1621           
Flag Coverage Δ
javascript 50.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard/components/UndoRedoKeyListeners/index.jsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cec0c9...6b6e598. Read the comment docs.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stephenLYZ stephenLYZ closed this Jan 23, 2022
@stephenLYZ stephenLYZ reopened this Jan 23, 2022
@zhaoyongjie zhaoyongjie merged commit a2bad75 into apache:master Jan 27, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants