Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused ts-jest #17996

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jan 11, 2022

SUMMARY

Currenttly, ts-jest is just used to import some esm module from react-select/src. We can use import type to avoid it, so we can remove ts-jest and keep default transform in jest.config.js.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #17996 (a96b703) into master (3d829fc) will decrease coverage by 0.75%.
The diff coverage is n/a.

❗ Current head a96b703 differs from pull request most recent head e19653b. Consider uploading reports for the commit e19653b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17996      +/-   ##
==========================================
- Coverage   67.06%   66.31%   -0.76%     
==========================================
  Files        1612     1569      -43     
  Lines       64999    61554    -3445     
  Branches     6872     6232     -640     
==========================================
- Hits        43594    40817    -2777     
+ Misses      19538    19138     -400     
+ Partials     1867     1599     -268     
Flag Coverage Δ
javascript 50.86% <ø> (-2.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/Select/DeprecatedSelect.tsx 37.33% <ø> (-8.23%) ⬇️
superset-frontend/src/components/Select/styles.tsx 67.92% <ø> (+1.82%) ⬆️
superset-frontend/src/components/Slider/index.tsx 0.00% <0.00%> (-75.00%) ⬇️
.../src/explore/components/controls/HiddenControl.tsx 0.00% <0.00%> (-75.00%) ⬇️
...t-frontend/src/filters/components/GroupBy/index.ts 0.00% <0.00%> (-66.67%) ⬇️
...ntend/src/filters/components/GroupBy/buildQuery.ts 0.00% <0.00%> (-66.67%) ⬇️
...end/src/filters/components/TimeGrain/buildQuery.ts 0.00% <0.00%> (-66.67%) ⬇️
...nd/src/filters/components/TimeColumn/buildQuery.ts 0.00% <0.00%> (-66.67%) ⬇️
...ols/DateFilterControl/components/CalendarFrame.tsx 0.00% <0.00%> (-42.86%) ⬇️
...c/dashboard/components/FilterBoxMigrationModal.tsx 33.33% <0.00%> (-41.67%) ⬇️
... and 469 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91b9a6...e19653b. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 LGTM!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 46715b2 into apache:master Jan 11, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants