Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package.json local file dependencies #17957

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jan 6, 2022

SUMMARY

According to NPM docs this is the proper way to reference local files in dependencies

TESTING INSTRUCTIONS

CI, ensure npm install works and everything builds properly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @zhaoyongjie @ktmud @graceguo-supercat

@etr2460 etr2460 force-pushed the erik-ritter--fix-package-json branch from 0d2ef7a to bd843ea Compare January 6, 2022 23:20
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #17957 (65e9203) into master (f75908b) will not change coverage.
The diff coverage is n/a.

❗ Current head 65e9203 differs from pull request most recent head bd843ea. Consider uploading reports for the commit bd843ea to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17957   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64905    64905           
  Branches     6868     6868           
=======================================
  Hits        43537    43537           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
javascript 53.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75908b...bd843ea. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review January 7, 2022 01:14
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@zhaoyongjie zhaoyongjie merged commit 79b6dc2 into apache:master Jan 7, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants