-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migration for Tabbed Sql Editor #17925
refactor: Migration for Tabbed Sql Editor #17925
Conversation
1acb89d
to
ebb9b57
Compare
This looks great! But let's wait until we have the sibling PR ready and approved before merging this, in case we need to change the migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this just in case.
❗ Please consider rebasing your branch to avoid db migration conflicts. |
superset/migrations/versions/c53bae8f08dd_add_saved_query_foreign_key_to_tab_state.py
Show resolved
Hide resolved
ebb9b57
to
a8b27ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
* a lot of console logs * migration for tabbed Sql Editors
* a lot of console logs * migration for tabbed Sql Editors
SUMMARY
This is the first portion of a larger bug issue of retaining a query's saved status when refreshing the page in sql lab. In order to create this we needed to create a foreign key in the tab state view that links it to the saved query.
This migration does that, and the subsequent logic is here: #17771
Benchmark
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION