Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): service account apiVersion indentation #17920

Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix(helm): service account apiVersion indentation #17920

merged 1 commit into from
Jan 4, 2022

Conversation

wiktor2200
Copy link
Contributor

SUMMARY

Fixing a bug while wrong indentation commented out apiVersion section along with license manifest.
Fix for #17880 PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Helm chart configure and create custom service account #17879
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@wiktor2200
Copy link
Contributor Author

wiktor2200 commented Jan 4, 2022 •
edited
Loading

Hi @craig-rueda could you approve and merge this fix for #17880? I missed this - while adding license manifest in comment :(

@wiktor2200 wiktor2200 mentioned this pull request Jan 4, 2022
Closed
9 tasks
@nytai nytai merged commit 48d5dc1 into apache:master Jan 4, 2022
@wiktor2200 wiktor2200 mentioned this pull request Jan 4, 2022
Closed
@ad-m ad-m mentioned this pull request Jan 21, 2022
Closed
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@wiktor2200 @shcoderAlex
fix(helm): service account apiVersion indent (apache#17920)
24ad379
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@wiktor2200 @bwang221
fix(helm): service account apiVersion indent (apache#17920)
a81ba43
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiktor2200 @nytai @mistercrunch