-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cypress): flake cypress test case #17918
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17918 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64899 64899
Branches 6866 6866
=======================================
Hits 43533 43533
Misses 19500 19500
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also seeing this one flake in one of my PRs - I'm curious if you know how this has been passing if the row counts have been off? I assume we haven't done any changes lately that would have affected these assertions..
We don't set an absolute time filter, but a relative one - minus 40 years. The year has changed 4 days ago and we've cut out 1 result. |
Lol, I look forward to redoing this in January 2023 😆 |
Let's merge this PR, but I hope we can fix this properly becuase it's ridiculous 😆 |
SUMMARY
Currently, the master branch has been blocked by a flake test from cypress. This PR fixes it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Cypress guaranteed
ADDITIONAL INFORMATION