Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-table): move adhoc filters control closer to the metrics #17797

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

In most charts adhoc filters control is placed next to the metrics controls. This PR moves adhoc filters control from the bottom of control panel, so that it's next to the metrics for consistency with other charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #17797 (ed9e7a5) into master (9c9edbe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17797   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files        1609     1609           
  Lines       64796    64796           
  Branches     6855     6855           
=======================================
  Hits        43530    43530           
  Misses      19410    19410           
  Partials     1856     1856           
Flag Coverage Δ
javascript 53.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 16.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9edbe...ed9e7a5. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and agree with the change, but would be nice to get design to stamp slso

@kasiazjc
Copy link
Contributor

lgtm 👍 It's a quick win, later we will focus on more enhancements in explore and control panel.

@kgabryje kgabryje merged commit a2d8b94 into apache:master Dec 17, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants