Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New Members per Month time range #17783

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix: New Members per Month time range #17783

merged 1 commit into from
Dec 16, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Dec 16, 2021 •
edited
Loading

SUMMARY

The "New Members per Month" chart in the examples has a default time range without data.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2021-12-16 at 10-28-11 DEV New Members per Month

After:

Screenshot 2021-12-16 at 10-25-51 DEV New Members per Month

TESTING INSTRUCTIONS

Run superset load-examples, the "Slack Dashboard" should show the chart with data.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida merged commit d9acb28 into master Dec 16, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@betodealmeida @shcoderAlex
fix: New Members per Month time range (apache#17783)
46614f7
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@betodealmeida @bwang221
fix: New Members per Month time range (apache#17783)
1b3dfdf
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix_chart_timerange branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinify srinify srinify approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betodealmeida @srinify @mistercrunch