-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update fixtures scope that are loading data into the analytical db #17780
chore: update fixtures scope that are loading data into the analytical db #17780
Conversation
179755c
to
07a5ed7
Compare
07a5ed7
to
6854d0d
Compare
f341163
to
1fde0ce
Compare
1fde0ce
to
e5b521e
Compare
Codecov Report
@@ Coverage Diff @@
## master #17780 +/- ##
==========================================
+ Coverage 67.72% 67.79% +0.07%
==========================================
Files 1605 1605
Lines 64205 64207 +2
Branches 6790 6790
==========================================
+ Hits 43481 43529 +48
+ Misses 18868 18822 -46
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I've been working on converting integration tests to unit tests, hopefully we can keep the number of integration tests down to a bare minimum in the near future.
SUMMARY
Play with fixture scopes to see if tests will be faster
Hive and presto DBs are slow, we should load test data only once rather than do it for every module / test function
Speed improvements:
Python Presto/Hive / test-postgres-presto (3.8) 38m vs 92 m
Python Presto/Hive / test-postgres-hive 39m vs 53 m
There are probably other tests as well that can benefit from a similar improvement