Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip flaky tests #17772

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Dec 15, 2021

SUMMARY

Skip tests that has been failing frequently in Hive.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #17772 (31e2cc6) into master (82b47ca) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17772      +/-   ##
==========================================
+ Coverage   67.71%   67.78%   +0.06%     
==========================================
  Files        1605     1605              
  Lines       64198    64198              
  Branches     6790     6790              
==========================================
+ Hits        43474    43518      +44     
+ Misses      18868    18824      -44     
  Partials     1856     1856              
Flag Coverage Δ
hive 81.79% <ø> (-0.01%) ⬇️
mysql 82.17% <ø> (ø)
postgres 82.22% <ø> (ø)
presto 82.09% <ø> (?)
python 82.71% <ø> (+0.14%) ⬆️
sqlite 81.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.34%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b47ca...31e2cc6. Read the comment docs.

@betodealmeida betodealmeida changed the title chore: skip flaky test chore: skip flaky tests Dec 15, 2021
@betodealmeida betodealmeida merged commit c18d486 into apache:master Dec 16, 2021
@amitmiran137
Copy link
Member

this is a very hacky solution
instead we could pass very specific marks to run only chart/data and SQL json tests
something like
scripts/python.tests.sh -m "chart_data_flow or sql_json_flow"
inside the relevant workflows like here: https://github.com/apache/superset/blob/master/.github/workflows/superset-python-presto-hive.yml#L83

chart_data_flow mark already exists .
sql_json_flow just need to be added under the relevant tests

@betodealmeida WDYT?

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants