Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print test runtime #17770

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Dec 15, 2021

SUMMARY

Print python test runtime

E.g.
image

@bkyryliuk bkyryliuk marked this pull request as draft December 15, 2021 19:04
@bkyryliuk bkyryliuk marked this pull request as ready for review December 15, 2021 19:34
@bkyryliuk bkyryliuk changed the title chore: print test runtime [WIP] chore: print test runtime Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #17770 (af43318) into master (4fd6df9) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head af43318 differs from pull request most recent head accf29c. Consider uploading reports for the commit accf29c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17770      +/-   ##
==========================================
- Coverage   67.71%   67.59%   -0.12%     
==========================================
  Files        1605     1605              
  Lines       64200    64200              
  Branches     6790     6790              
==========================================
- Hits        43476    43399      -77     
- Misses      18868    18945      +77     
  Partials     1856     1856              
Flag Coverage Δ
hive ?
mysql 82.17% <ø> (ø)
postgres 82.22% <ø> (ø)
python 82.30% <ø> (-0.26%) ⬇️
sqlite 81.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-0.84%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-0.23%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd6df9...accf29c. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's really useful info for debugging slow test cases.

@bkyryliuk bkyryliuk merged commit bcd698d into apache:master Dec 16, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* Print test runtime

* revert me

* duration for unit tests as well

* Revert "revert me"

This reverts commit b82d701d65f97ba617c4fc89e0ff56eee74885f2.

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* Print test runtime

* revert me

* duration for unit tests as well

* Revert "revert me"

This reverts commit b82d701d65f97ba617c4fc89e0ff56eee74885f2.

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants