Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase #17769

Merged
merged 4 commits into from
Dec 17, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

The Pivot Table v2 chart is based on a forked and heavily modified library react-pivottable.
The fork is available here: https://github.com/apache-superset/react-pivottable

Since the monorepo project is finished and we've migrated our viz plugins to the main repo, it's a good time to do the same to react-pivottable fork.
Currently very few people are aware of existence of that repo and even fewer contribute to it (to be precise, only I do). Moving that repo to the main codebase would make it easier for community contributors to work on improving and maintaining the Pivot Table chart.
I'm not concerned about keeping our version of react-pivottable in sync with the original - it hasn't been updated for over the year.
After this PR is accepted and merged, https://github.com/apache-superset/react-pivottable will be archived.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Everything should look and work the same as before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

https://app.shortcut.com/preset/story/33685/migrate-react-pivottable-fork-repo-into-main-superset-repo

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this relocation!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested to work well - good to go once CI is green 👍

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #17769 (e18bfdc) into master (124af4c) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17769      +/-   ##
==========================================
- Coverage   67.71%   67.10%   -0.62%     
==========================================
  Files        1604     1609       +5     
  Lines       64186    64785     +599     
  Branches     6786     6855      +69     
==========================================
+ Hits        43464    43474      +10     
- Misses      18867    19455     +588     
- Partials     1855     1856       +1     
Flag Coverage Δ
javascript 53.90% <0.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...rt-pivot-table/src/react-pivottable/PivotTable.jsx 0.00% <0.00%> (ø)
...n-chart-pivot-table/src/react-pivottable/Styles.js 0.00% <0.00%> (ø)
...ivot-table/src/react-pivottable/TableRenderers.jsx 0.00% <0.00%> (ø)
...hart-pivot-table/src/react-pivottable/utilities.js 0.00% <0.00%> (ø)
...src/dashboard/components/PropertiesModal/index.tsx 66.03% <0.00%> (-0.85%) ⬇️
...DataTable/utils/sortAlphanumericCaseInsensitive.ts 100.00% <0.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 53.54% <0.00%> (+0.12%) ⬆️
...et-frontend/src/dashboard/actions/nativeFilters.ts 44.31% <0.00%> (+0.49%) ⬆️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 38.54% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124af4c...e18bfdc. Read the comment docs.

@kgabryje kgabryje merged commit 9c9edbe into apache:master Dec 17, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…et codebase (apache#17769)

* chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase

* Fix lint errors

* Use named export

* Clean up the code
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…et codebase (apache#17769)

* chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase

* Fix lint errors

* Use named export

* Clean up the code
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants