-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase #17769
chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase #17769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this relocation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested to work well - good to go once CI is green 👍
Codecov Report
@@ Coverage Diff @@
## master #17769 +/- ##
==========================================
- Coverage 67.71% 67.10% -0.62%
==========================================
Files 1604 1609 +5
Lines 64186 64785 +599
Branches 6786 6855 +69
==========================================
+ Hits 43464 43474 +10
- Misses 18867 19455 +588
- Partials 1855 1856 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…et codebase (apache#17769) * chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase * Fix lint errors * Use named export * Clean up the code
…et codebase (apache#17769) * chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase * Fix lint errors * Use named export * Clean up the code
SUMMARY
The Pivot Table v2 chart is based on a forked and heavily modified library react-pivottable.
The fork is available here: https://github.com/apache-superset/react-pivottable
Since the monorepo project is finished and we've migrated our viz plugins to the main repo, it's a good time to do the same to react-pivottable fork.
Currently very few people are aware of existence of that repo and even fewer contribute to it (to be precise, only I do). Moving that repo to the main codebase would make it easier for community contributors to work on improving and maintaining the Pivot Table chart.
I'm not concerned about keeping our version of react-pivottable in sync with the original - it hasn't been updated for over the year.
After this PR is accepted and merged, https://github.com/apache-superset/react-pivottable will be archived.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Everything should look and work the same as before
ADDITIONAL INFORMATION
https://app.shortcut.com/preset/story/33685/migrate-react-pivottable-fork-repo-into-main-superset-repo