-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dataset extra import/export #17740
Conversation
22d5108
to
fdc61a1
Compare
603a70e
to
5d52ab8
Compare
31e3cfa
to
8cf9c7c
Compare
8cf9c7c
to
13f21d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #17740 +/- ##
==========================================
- Coverage 67.71% 67.61% -0.11%
==========================================
Files 1605 1605
Lines 64198 64218 +20
Branches 6790 6790
==========================================
- Hits 43474 43418 -56
- Misses 18868 18944 +76
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left a nit question
* fix: dataset extra import/export * Update superset/datasets/commands/importers/v1/utils.py
* fix: dataset extra import/export * Update superset/datasets/commands/importers/v1/utils.py
SUMMARY
The
extra
attribute from datasets is being imported as a string. The resulting YAML looks like this:When it should look like this:
I fixed the export to run
json.load
on the field before the export, and fixed the import to support both formats.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
I added unit tests covering the export, and imports for the old and new format.
ADDITIONAL INFORMATION