Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix UPDATING.md #17717

Merged
merged 2 commits into from
Dec 24, 2021
Merged

chore: Fix UPDATING.md #17717

merged 2 commits into from
Dec 24, 2021

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Dec 10, 2021

SUMMARY

@ofekisr #17539 is a breaking change however it does not require downtime.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -31,13 +31,11 @@ assists people when migrating to a new version.
- [17290](https://github.com/apache/superset/pull/17290): Bumps pandas to `1.3.4` and pyarrow to `5.0.0`
- [16660](https://github.com/apache/incubator-superset/pull/16660): The `columns` Jinja parameter has been renamed `table_columns` to make the `columns` query object parameter available in the Jinja context.
- [16711](https://github.com/apache/incubator-superset/pull/16711): The `url_param` Jinja function will now by default escape the result. For instance, the value `O'Brien` will now be changed to `O''Brien`. To disable this behavior, call `url_param` with `escape_result` set to `False`: `url_param("my_key", "my default", escape_result=False)`.
- [17539](https://github.com/apache/superset/pull/17539): all Superset CLI commands (init, load_examples and etc) require setting the FLASK_APP environment variable (which is set by default when `.flaskenv` is loaded)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this has also be made a one line statement. Wrapping should be handled by the browser rather than by manually adding newline characters.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #17717 (8673072) into master (37cc2c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17717   +/-   ##
=======================================
  Coverage   67.73%   67.73%           
=======================================
  Files        1602     1602           
  Lines       64152    64152           
  Branches     6774     6774           
=======================================
  Hits        43451    43451           
  Misses      18848    18848           
  Partials     1853     1853           
Flag Coverage Δ
hive 81.79% <ø> (ø)
javascript 54.84% <ø> (ø)
mysql 82.16% <ø> (ø)
postgres 82.22% <ø> (ø)
python 82.56% <ø> (ø)
sqlite 81.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cc2c4...8673072. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amitmiran137 amitmiran137 merged commit f8a65f8 into master Dec 24, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
Co-authored-by: Srini Kadamati <skadamat@gmail.com>
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
Co-authored-by: Srini Kadamati <skadamat@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley--fix-updating branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants