Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename CertifiedIcon to CertifiedBadge #17715

Merged
merged 1 commit into from
Dec 10, 2021
Merged

chore: Rename CertifiedIcon to CertifiedBadge #17715

merged 1 commit into from
Dec 10, 2021

Conversation

geido
Copy link
Member

@geido geido commented Dec 10, 2021

SUMMARY

Renames CertifiedIcon to CertifiedBadge

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this more sensible!

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #17715 (7319a4d) into master (8de9387) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17715      +/-   ##
==========================================
- Coverage   68.14%   68.13%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       66376    66376              
  Branches     7121     7121              
==========================================
- Hits        45230    45227       -3     
- Misses      19250    19252       +2     
- Partials     1896     1897       +1     
Flag Coverage Δ
javascript 56.25% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Datasource/DatasourceEditor.jsx 68.85% <ø> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 46.57% <ø> (ø)
...t-frontend/src/components/CertifiedBadge/index.tsx 100.00% <100.00%> (ø)
...et-frontend/src/components/EditableTitle/index.tsx 73.07% <100.00%> (ø)
...set-frontend/src/components/ListViewCard/index.tsx 93.75% <100.00%> (ø)
...et-frontend/src/components/TableSelector/index.tsx 68.08% <100.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 62.14% <100.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 63.35% <100.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 62.65% <100.00%> (ø)
.../explore/components/controls/TextControl/index.tsx 72.22% <0.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de9387...7319a4d. Read the comment docs.

@rusackas rusackas merged commit 4b96971 into apache:master Dec 10, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants