Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unblock ci on postgres lint #17705

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 9, 2021

SUMMARY

Unblock CI due to typeshed updates made here earlier today: python/typeshed#6551

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ
Copy link
Member

LGTM

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #17705 (f075f8e) into master (04e3cfa) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17705      +/-   ##
==========================================
- Coverage   68.13%   67.95%   -0.19%     
==========================================
  Files        1653     1653              
  Lines       66247    66247              
  Branches     7107     7107              
==========================================
- Hits        45138    45017     -121     
- Misses      19220    19341     +121     
  Partials     1889     1889              
Flag Coverage Δ
hive ?
mysql 82.13% <100.00%> (ø)
postgres 82.14% <100.00%> (ø)
presto ?
python 82.22% <100.00%> (-0.41%) ⬇️
sqlite 81.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/postgres.py 97.36% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.27% <0.00%> (-16.99%) ⬇️
superset/db_engine_specs/presto.py 83.50% <0.00%> (-6.89%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 86.85% <0.00%> (-1.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.29% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3cfa...f075f8e. Read the comment docs.

@villebro villebro merged commit 1af99ea into apache:master Dec 9, 2021
@villebro villebro deleted the villebro/postgres-unblock-ci branch December 9, 2021 14:13
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants