Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(Dashboard): Only apply changes when editing properties" #17618

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

geido
Copy link
Member

@geido geido commented Dec 1, 2021

Reverts #17392

We found that the onlyApply tag was only partially working as the implementation was partial in both the frontend and the backend. I am working on the full implementation here #17570. However, we should revert the #17392 PR in the meantime to avoid issues with the upcoming release.

@geido geido changed the title Revert "fix(Dashboard): Only apply changes when editing properties" fix: Revert "fix(Dashboard): Only apply changes when editing properties" Dec 1, 2021
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #17618 (b4c0d14) into master (1cd07ca) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17618      +/-   ##
==========================================
+ Coverage   68.36%   68.55%   +0.18%     
==========================================
  Files        1601     1601              
  Lines       65260    65260              
  Branches     6963     6963              
==========================================
+ Hits        44616    44737     +121     
+ Misses      18754    18633     -121     
  Partials     1890     1890              
Flag Coverage Δ
hive 81.38% <ø> (?)
javascript 57.07% <ø> (ø)
mysql 81.80% <ø> (ø)
postgres 81.81% <ø> (ø)
presto 81.68% <ø> (?)
python 82.30% <ø> (+0.40%) ⬆️
sqlite 81.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/dashboard/components/Header/index.jsx 59.02% <ø> (ø)
superset/utils/core.py 89.76% <0.00%> (+0.11%) ⬆️
superset/db_engine_specs/base.py 88.54% <0.00%> (+0.38%) ⬆️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.57%) ⬆️
superset/views/database/mixins.py 82.75% <0.00%> (+1.72%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.88%) ⬆️
superset/db_engine_specs/hive.py 87.25% <0.00%> (+16.98%) ⬆️
superset/db_engines/hive.py 85.18% <0.00%> (+85.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd07ca...b4c0d14. Read the comment docs.

@rusackas rusackas merged commit 8963cca into master Dec 1, 2021
@rusackas rusackas deleted the revert-17392-fix/issue_17243_discard_changes branch December 1, 2021 18:36
@jinghua-qa
Copy link
Member

🏷️ 2021.46

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 1, 2021
@rusackas rusackas added the v1.4 label Dec 6, 2021
@eschutho eschutho removed the v1.4 label Dec 8, 2021
@eschutho
Copy link
Member

eschutho commented Dec 8, 2021

@geido @rusackas I removed the v1.4 label as the original code that this PR reverts isn't in v1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants