-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "fix(Dashboard): Only apply changes when editing properties" #17618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #17618 +/- ##
==========================================
+ Coverage 68.36% 68.55% +0.18%
==========================================
Files 1601 1601
Lines 65260 65260
Branches 6963 6963
==========================================
+ Hits 44616 44737 +121
+ Misses 18754 18633 -121
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷️ 2021.46 |
…pache#17392)" (apache#17618) This reverts commit 0712be4. (cherry picked from commit 8963cca)
Reverts #17392
We found that the
onlyApply
tag was only partially working as the implementation was partial in both the frontend and the backend. I am working on the full implementation here #17570. However, we should revert the #17392 PR in the meantime to avoid issues with the upcoming release.