Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump mysqlclient version #17556

Merged
merged 4 commits into from
Nov 29, 2021
Merged

chore: bump mysqlclient version #17556

merged 4 commits into from
Nov 29, 2021

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Nov 26, 2021

SUMMARY

MySQLClient 1.4.2post1 is quite old, and it's time to update to fix bugs.
v2.1.0 supports multiple statements in default. We could issue set @T=1; select @T; when Allow DML is true.
The change log could refer to https://github.com/PyMySQL/mysqlclient/blob/main/HISTORY.rst

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@gnought gnought changed the title Bump mysqlclient version chore: Bump mysqlclient version Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #17556 (f57884a) into master (7429282) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17556   +/-   ##
=======================================
  Coverage   76.95%   76.96%           
=======================================
  Files        1049     1049           
  Lines       56671    56681   +10     
  Branches     7851     7851           
=======================================
+ Hits        43611    43622   +11     
+ Misses      12807    12806    -1     
  Partials      253      253           
Flag Coverage Δ
hive 81.61% <ø> (+<0.01%) ⬆️
mysql 82.02% <ø> (+<0.01%) ⬆️
postgres 82.03% <ø> (+<0.01%) ⬆️
python 82.38% <ø> (+<0.01%) ⬆️
sqlite 81.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cli.py 54.82% <0.00%> (-0.11%) ⬇️
superset/constants.py 100.00% <0.00%> (ø)
superset/datasets/api.py 91.03% <0.00%> (+0.89%) ⬆️
superset/db_engine_specs/trino.py 63.85% <0.00%> (+4.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7429282...f57884a. Read the comment docs.

@villebro
Copy link
Member

@gnought can you add some context in the description why the bump is needed.

@gnought gnought changed the title chore: Bump mysqlclient version chore: bump mysqlclient version Nov 26, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnought thanks for adding context to the description 👍 I hadn't noticed we had conflicting versions of mysqlclient on setup.py and requirements/development.(in|txt). As I see some removals/deprecations on the 2.x version, It could be a good idea to add a note to UPDATING.md to make sure people/orgs that are currently running the 1.x version make sure they make any necessary changes to their connection configs.

setup.py Outdated Show resolved Hide resolved
gnought and others added 2 commits November 28, 2021 03:22
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 94e787e into apache:master Nov 29, 2021
@gnought gnought deleted the feature/mysqlclient_upgrade branch November 29, 2021 18:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants