Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(translations): fix translation literals #17501

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

villebro
Copy link
Member

SUMMARY

When reviewing a translation PR, I noticed many incorrect translation literals. This fixes all translations I could find that either "burned in" the variable into the translation string or were incorrectly constructed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #17501 (45fb9ce) into master (062039c) will decrease coverage by 0.20%.
The diff coverage is 84.98%.

❗ Current head 45fb9ce differs from pull request most recent head 68678ea. Consider uploading reports for the commit 68678ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17501      +/-   ##
==========================================
- Coverage   76.97%   76.77%   -0.21%     
==========================================
  Files        1045     1046       +1     
  Lines       56442    56491      +49     
  Branches     7798     7798              
==========================================
- Hits        43449    43373      -76     
- Misses      12737    12862     +125     
  Partials      256      256              
Flag Coverage Δ
hive ?
mysql 81.99% <90.17%> (+0.01%) ⬆️
postgres 82.00% <90.17%> (+0.01%) ⬆️
presto ?
python 82.09% <90.17%> (-0.40%) ⬇️
sqlite 81.68% <90.17%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/App/index.jsx 56.66% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 61.48% <ø> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js 28.96% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 88.18% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 52.76% <0.00%> (ø)
superset/databases/commands/exceptions.py 94.00% <ø> (ø)
.../src/views/CRUD/alert/components/RecipientIcon.tsx 60.86% <20.00%> (ø)
...rc/views/CRUD/alert/components/AlertStatusIcon.tsx 46.96% <31.25%> (ø)
superset/charts/post_processing.py 67.20% <50.00%> (-0.28%) ⬇️
superset/charts/data/api.py 88.00% <75.00%> (+0.08%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062039c...68678ea. Read the comment docs.

@hbruch
Copy link
Contributor

hbruch commented Nov 22, 2021

I'd suggest you include *.ts in babel.cfg and regenerate the pot-File with this PR. I'll rebase my PR #17478 on this and add missing translations then.

Files/Messages you probably could include in this PR also:
/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx (Viewed/Modified)
/superset-frontend/src/views/CRUD/welcome/DashbaordTable.tsx and ChartTable (View All >>)
/superset-frontend/src/components/Menu/MenueRight.tsx(SubMenu title=Settings)

Copy link
Contributor

@hbruch hbruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. As commented above, I suggest to add a few literals to this PR and include an updated pot file.

superset-frontend/src/views/CRUD/welcome/EmptyState.tsx Outdated Show resolved Hide resolved
@villebro
Copy link
Member Author

I'd suggest you include *.ts in babel.cfg and regenerate the pot-File with this PR. I'll rebase my PR #17478 on this and add missing translations then.

Files/Messages you probably could include in this PR also: /superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx (Viewed/Modified) /superset-frontend/src/views/CRUD/welcome/DashbaordTable.tsx and ChartTable (View All >>) /superset-frontend/src/components/Menu/MenueRight.tsx(SubMenu title=Settings)

As this PR is already getting fairly big, I'd like to keep the scope of the changes as small as possible. As you were the person that noticed the missing ts translations, would you be open to opening a PR to fix that bug? If not I'm happy to do it, too, but I would love to see the fix attributed to the correct person 👍

@villebro villebro merged commit 5d1c907 into apache:master Nov 23, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* chore(translations): fix translation literals

* fix table name types and translations

* fix lint

* join concat'd messages
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants