-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(translations): fix translation literals #17501
Conversation
d2441cb
to
0e80918
Compare
Codecov Report
@@ Coverage Diff @@
## master #17501 +/- ##
==========================================
- Coverage 76.97% 76.77% -0.21%
==========================================
Files 1045 1046 +1
Lines 56442 56491 +49
Branches 7798 7798
==========================================
- Hits 43449 43373 -76
- Misses 12737 12862 +125
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I'd suggest you include Files/Messages you probably could include in this PR also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. As commented above, I suggest to add a few literals to this PR and include an updated pot
file.
As this PR is already getting fairly big, I'd like to keep the scope of the changes as small as possible. As you were the person that noticed the missing |
6aaa9a7
to
031e14e
Compare
3d34a81
to
6054708
Compare
* chore(translations): fix translation literals * fix table name types and translations * fix lint * join concat'd messages
SUMMARY
When reviewing a translation PR, I noticed many incorrect translation literals. This fixes all translations I could find that either "burned in" the variable into the translation string or were incorrectly constructed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION