fix: create-admin command in Makefile #17471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17471 +/- ##
=======================================
Coverage 76.94% 76.94%
=======================================
Files 1042 1042
Lines 56312 56312
Branches 7793 7793
=======================================
Hits 43329 43329
Misses 12727 12727
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ryankubin
approved these changes
Nov 18, 2021
ryankubin
approved these changes
Nov 18, 2021
eschutho
reviewed
Nov 18, 2021
Makefile
Outdated
| --username admin \ | ||
| --firstname Admin \ | ||
| --lastname Strator \ | ||
| --email admin@apache.org \ |
There was a problem hiding this comment.
lol not sure let me change it
eschutho
approved these changes
Nov 18, 2021
ofekisr
reviewed
Nov 18, 2021
| --firstname Admin \ | ||
| --lastname Strator \ | ||
| --email admin@superset.io \ | ||
| --password admin |
There was a problem hiding this comment.
please change the password to "general"
or change all the test fixtures that add an admin user, the password to admin
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* update make file * Update Makefile
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a user runs
make installthe load-examples section would fail if the user didn't create an user with usernameadmin. To fix this I've update the install command to create an admin user by default and added amake admin-userfor users who need to create a specific Admin userBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION