Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presto): expand data with null item #17470

Merged
merged 2 commits into from
Nov 21, 2021
Merged

fix(presto): expand data with null item #17470

merged 2 commits into from
Nov 21, 2021

Conversation

ganczarek
Copy link
Contributor

SUMMARY

A simple fix for #17469

TESTING INSTRUCTIONS

Run Presto engine tests:

tox -e py38 -- tests/integration_tests/db_engine_specs/presto_tests.py

ADDITIONAL INFORMATION

  • Has associated issue: Presto engine: zip argument #1 must support iteration #17469
  • Required feature flags: PRESTO_EXPAND_DATA
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #17470 (f510ad3) into master (211b32a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17470   +/-   ##
=======================================
  Coverage   76.94%   76.95%           
=======================================
  Files        1042     1043    +1     
  Lines       56254    56324   +70     
  Branches     7785     7785           
=======================================
+ Hits        43286    43345   +59     
- Misses      12710    12721   +11     
  Partials      258      258           
Flag Coverage Δ
hive 81.53% <100.00%> (+<0.01%) ⬆️
mysql 81.96% <100.00%> (+<0.01%) ⬆️
postgres 81.97% <100.00%> (+<0.01%) ⬆️
presto 81.84% <100.00%> (+<0.01%) ⬆️
python 82.47% <100.00%> (+<0.01%) ⬆️
sqlite 81.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 90.39% <100.00%> (+0.02%) ⬆️
superset/tasks/async_queries.py 91.02% <0.00%> (-5.95%) ⬇️
superset/charts/data/api.py 87.91% <0.00%> (-0.66%) ⬇️
superset/dashboards/dao.py 96.09% <0.00%> (-0.04%) ⬇️
superset/common/query_object_factory.py 89.79% <0.00%> (ø)
superset/common/query_context.py 92.00% <0.00%> (+0.14%) ⬆️
superset/common/query_object.py 93.06% <0.00%> (+0.16%) ⬆️
superset/charts/data/commands.py 100.00% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211b32a...f510ad3. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ganczarek + the awesome unit test! One comment before submitting this for broader review.

superset/db_engine_specs/presto.py Show resolved Hide resolved
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but asking for a second pair of eyes

@villebro
Copy link
Member

@john-bodley could you take a look and see if you agree with this change?

@villebro
Copy link
Member

Since this is plugging a very specific bug, has very low risk of introducing regressions and adds good tests, I'll go ahead and merge this (we can do incremental improvements on this functionality later if needed).

@villebro villebro merged commit 8da982b into apache:master Nov 21, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* fix(presto): expand data with null item

* Fixed pre-commit check
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants